diff options
| author | jyn <github@jyn.dev> | 2025-03-11 00:24:08 -0400 |
|---|---|---|
| committer | jyn <github@jyn.dev> | 2025-04-13 16:46:02 -0400 |
| commit | d50a8d5fb3727277f82440524e20a67e29dead4c (patch) | |
| tree | 78acdfd39a727bccd0be62d614758cf9d2e4005c /compiler/rustc_ast/src | |
| parent | 092a284ba0421695f2032c947765429fd7095796 (diff) | |
| download | rust-d50a8d5fb3727277f82440524e20a67e29dead4c.tar.gz rust-d50a8d5fb3727277f82440524e20a67e29dead4c.zip | |
Improve `-Z crate-attr` diagnostics
- Show the `#![ ... ]` in the span (to make it clear that it should not be included in the CLI argument) - Show more detailed errors when the crate has valid token trees but invalid syntax. Previously, `crate-attr=feature(foo),feature(bar)` would just say "invalid crate attribute" and point at the comma. Now, it explicitly says that the comma was unexpected, which is useful when using `--error-format=short`. It also fixes the column to show the correct span. - Recover from parse errors. Previously we would abort immediately on syntax errors; now we go on to try and type-check the rest of the crate. The new diagnostic code also happens to be slightly shorter.
Diffstat (limited to 'compiler/rustc_ast/src')
| -rw-r--r-- | compiler/rustc_ast/src/attr/mod.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/rustc_ast/src/attr/mod.rs b/compiler/rustc_ast/src/attr/mod.rs index 0b65246693d..d656d9b0b8a 100644 --- a/compiler/rustc_ast/src/attr/mod.rs +++ b/compiler/rustc_ast/src/attr/mod.rs @@ -627,7 +627,7 @@ pub fn mk_doc_comment( Attribute { kind: AttrKind::DocComment(comment_kind, data), id: g.mk_attr_id(), style, span } } -pub fn mk_attr( +fn mk_attr( g: &AttrIdGenerator, style: AttrStyle, unsafety: Safety, |