diff options
| author | Mara Bos <m-ou.se@m-ou.se> | 2022-08-25 14:49:09 +0200 | 
|---|---|---|
| committer | Mara Bos <m-ou.se@m-ou.se> | 2022-08-25 14:49:09 +0200 | 
| commit | 1b044da5bb87702a160537cf1137b8921b54ddd5 (patch) | |
| tree | 273e2bf000b57b7922f06b67dc9bfc39c1992e30 /compiler/rustc_builtin_macros/src/format.rs | |
| parent | 4d45b0745ab227feb9000bc15713ade4b99241ea (diff) | |
| download | rust-1b044da5bb87702a160537cf1137b8921b54ddd5.tar.gz rust-1b044da5bb87702a160537cf1137b8921b54ddd5.zip  | |
Separate CountIsStar from CountIsParam in rustc_parse_format.
Diffstat (limited to 'compiler/rustc_builtin_macros/src/format.rs')
| -rw-r--r-- | compiler/rustc_builtin_macros/src/format.rs | 12 | 
1 files changed, 6 insertions, 6 deletions
diff --git a/compiler/rustc_builtin_macros/src/format.rs b/compiler/rustc_builtin_macros/src/format.rs index 2816f81fef1..21004871075 100644 --- a/compiler/rustc_builtin_macros/src/format.rs +++ b/compiler/rustc_builtin_macros/src/format.rs @@ -541,7 +541,7 @@ impl<'a, 'b> Context<'a, 'b> { ) { match c { parse::CountImplied | parse::CountIs(..) => {} - parse::CountIsParam(i) => { + parse::CountIsParam(i) | parse::CountIsStar(i) => { self.unused_names_lint.maybe_add_positional_named_arg( self.args.get(i), named_arg_type, @@ -589,7 +589,7 @@ impl<'a, 'b> Context<'a, 'b> { + self .arg_with_formatting .iter() - .filter(|fmt| matches!(fmt.precision, parse::CountIsParam(_))) + .filter(|fmt| matches!(fmt.precision, parse::CountIsStar(_))) .count(); if self.names.is_empty() && !numbered_position_args && count != self.num_args() { e = self.ecx.struct_span_err( @@ -639,7 +639,7 @@ impl<'a, 'b> Context<'a, 'b> { if let Some(span) = fmt.precision_span { let span = self.fmtsp.from_inner(InnerSpan::new(span.start, span.end)); match fmt.precision { - parse::CountIsParam(pos) if pos > self.num_args() => { + parse::CountIsParam(pos) if pos >= self.num_args() => { e.span_label( span, &format!( @@ -651,12 +651,12 @@ impl<'a, 'b> Context<'a, 'b> { ); zero_based_note = true; } - parse::CountIsParam(pos) => { + parse::CountIsStar(pos) => { let count = self.pieces.len() + self .arg_with_formatting .iter() - .filter(|fmt| matches!(fmt.precision, parse::CountIsParam(_))) + .filter(|fmt| matches!(fmt.precision, parse::CountIsStar(_))) .count(); e.span_label( span, @@ -837,7 +837,7 @@ impl<'a, 'b> Context<'a, 'b> { }; match c { parse::CountIs(i) => count(sym::Is, Some(self.ecx.expr_usize(sp, i))), - parse::CountIsParam(i) => { + parse::CountIsParam(i) | parse::CountIsStar(i) => { // This needs mapping too, as `i` is referring to a macro // argument. If `i` is not found in `count_positions` then // the error had already been emitted elsewhere.  | 
