about summary refs log tree commit diff
path: root/compiler/rustc_codegen_gcc/src/errors.rs
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2022-11-21 14:11:12 +0100
committerGitHub <noreply@github.com>2022-11-21 14:11:12 +0100
commit5b9289215e0afb73efbf882e8d6f0af461fc99f2 (patch)
tree4794afab68078b80105749b4f5a81d12468f7927 /compiler/rustc_codegen_gcc/src/errors.rs
parented22bdc18f466f03737b4cdd8dba6d5524fb5389 (diff)
parent6f1c7b24705d8e744ddea9b445cb70e0a0d328cb (diff)
downloadrust-5b9289215e0afb73efbf882e8d6f0af461fc99f2.tar.gz
rust-5b9289215e0afb73efbf882e8d6f0af461fc99f2.zip
Rollup merge of #104628 - alex-pinkus:revert-android-ndk-upgrade, r=pietroalbini
Revert "Update CI to use Android NDK r25b"

This reverts commit bf7f1ca316a249cf99d722d79a0db12fef687142 (pull request #102332).

The relevant discussion can be found in #103673, where it was agreed that more time is needed to warn the community of the upcoming breakage.

This PR is for the `master` branch, where a conflict was recently introduced due to 6d8160261ff3aee3b6eaacc37ac96cafff530980. The conflict is in `cc_detect.rs`, where the code that corrects the target triple was moved to a new function called `ndk_compiler()`. This puts the old logic in the `ndk_compiler` function, and assumes that it works properly in the other location where that code is being called. I would appreciate review from ``@pietroalbini`` to understand how we can test that the reverted logic is also suitable for the additional use case (seems to be related to setting `cc` and `cxx`). I've confirmed already that with these changes I can compile for `armv7-linux-androideabi`, `aarch64-linux-android`, `i686-linux-android`, and `x86_64-linux-android` using `x.py`.

A separate revert for the `beta` branch will be required, since the original change has already made it to beta. The beta revert is available at https://github.com/alex-pinkus/rust/commit/3fa0d94674fbe37090ebe44ac1f06e2233f3121e, but I'm not sure of the process for staging that PR.
Diffstat (limited to 'compiler/rustc_codegen_gcc/src/errors.rs')
0 files changed, 0 insertions, 0 deletions