about summary refs log tree commit diff
path: root/compiler/rustc_codegen_gcc
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2022-06-06 05:21:49 +0000
committerbors <bors@rust-lang.org>2022-06-06 05:21:49 +0000
commit6609c6734de4df43e24d7672f8ae8786ecc8047e (patch)
treec2a811e80067397a33d43b596c251b5c56982c1c /compiler/rustc_codegen_gcc
parent760237ff785fd14ac7fdab799f4d695d86cf9cbf (diff)
parent8ea95988df4d493ec3f556ab0de6b0b812ed27be (diff)
downloadrust-6609c6734de4df43e24d7672f8ae8786ecc8047e.tar.gz
rust-6609c6734de4df43e24d7672f8ae8786ecc8047e.zip
Auto merge of #96551 - ferrocene:pa-ignore-paths-when-abbreviating, r=Mark-Simulacrum
[compiletest] Ignore known paths when abbreviating output

To prevent out of memory conditions, compiletest limits the amount of output a test can generate, abbreviating it if the test emits more than a threshold. While the behavior is desirable, it also causes some issues (like #96229, #94322 and #92211).

The latest one happened recently, when the `src/test/ui/numeric/numeric-cast.rs` test started to fail on systems where the path of the rust-lang/rust checkout is too long. This includes my own development machine and [LLVM's CI](https://github.com/rust-lang/rust/issues/96362#issuecomment-1108609893). Rust's CI uses a pretty short directory name for the checkout, which hides these sort of problems until someone runs the test suite on their own computer.

When developing the fix I tried to find the most targeted fix that would prevent this class of failures from happening in the future, deferring the decision on if/how to redesign abbreviation to a later date. The solution I came up with was to ignore known base paths when calculating whether the output exceeds the abbreviation threshold, which removes this kind of nondeterminism.

This PR is best reviewed commit-by-commit.
Diffstat (limited to 'compiler/rustc_codegen_gcc')
0 files changed, 0 insertions, 0 deletions