about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/messages.ftl
diff options
context:
space:
mode:
authorJubilee <workingjubilee@gmail.com>2024-11-07 18:48:20 -0800
committerGitHub <noreply@github.com>2024-11-07 18:48:20 -0800
commit60e8ab6ba8d005ff83d6e2e33e679375af5f74ec (patch)
tree042ba8b373029ef8762374dfbf23d898dce247d9 /compiler/rustc_codegen_llvm/messages.ftl
parentb91a3a05609a46f73d23e0995ae7ebb4a4f429a5 (diff)
parentb2fd8a0192f6a69a4fb969ab3d005b577a524371 (diff)
downloadrust-60e8ab6ba8d005ff83d6e2e33e679375af5f74ec.tar.gz
rust-60e8ab6ba8d005ff83d6e2e33e679375af5f74ec.zip
Rollup merge of #130586 - dpaoliello:fixrawdylib, r=wesleywiser
Set "symbol name" in raw-dylib import libraries to the decorated name

`windows-rs` received a bug report that mixing raw-dylib generated and the Windows SDK import libraries was causing linker failures: <https://github.com/microsoft/windows-rs/issues/3285>

The root cause turned out to be #124958, that is we are not including the decorated name in the import library and so the import name type is also not being correctly set.

This change modifies the generation of import libraries to set the "symbol name" to the fully decorated name and correctly marks the import as being data vs function.

Note that this also required some changes to how the symbol is named within Rust: for MSVC we now need to use the decorated name but for MinGW we still need to use partially decorated (or undecorated) name.

Fixes #124958

Passing i686 MSVC and MinGW build: <https://github.com/rust-lang/rust/actions/runs/11000433888?pr=130586>

r? `@ChrisDenton`
Diffstat (limited to 'compiler/rustc_codegen_llvm/messages.ftl')
0 files changed, 0 insertions, 0 deletions