diff options
| author | Niko Matsakis <niko@alum.mit.edu> | 2021-05-11 05:40:42 -0400 |
|---|---|---|
| committer | Niko Matsakis <niko@alum.mit.edu> | 2021-05-13 05:58:21 -0400 |
| commit | 89c58eac6826bf6067d4a1cb9d74b9b9282d4688 (patch) | |
| tree | 8bf452f133ecdddac998b13a8cfa095cd64883f9 /compiler/rustc_codegen_llvm/src/asm.rs | |
| parent | c7cb72828d2b4cd6f2b138a1b4efbdf6116901b5 (diff) | |
| download | rust-89c58eac6826bf6067d4a1cb9d74b9b9282d4688.tar.gz rust-89c58eac6826bf6067d4a1cb9d74b9b9282d4688.zip | |
have on_completion record subcycles
Rework `on_completion` method so that it removes all
provisional cache entries that are "below" a completed
node (while leaving those entries that are not below
the node).
This corrects an imprecise result that could in turn lead
to an incremental compilation failure. Under the old
scheme, if you had:
* A depends on...
* B depends on A
* C depends on...
* D depends on C
* T: 'static
then the provisional results for A, B, C, and D would all
be entangled. Thus, if A was `EvaluatedToOkModuloRegions`
(because of that final condition), then the result for C and
D would also be demoted to "ok modulo regions".
In reality, though, the result for C depends only on C and itself,
and is not dependent on regions. If we happen to evaluate the
cycle starting from C, we would never reach A, and hence the
result would be "ok".
Under the new scheme, the provisional results for C and D
are moved to the permanent cache immediately and are not affected
by the result of A.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/asm.rs')
0 files changed, 0 insertions, 0 deletions