about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/attributes.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-04-08 07:23:04 +0000
committerbors <bors@rust-lang.org>2021-04-08 07:23:04 +0000
commit69e1d22ddbc67b25141a735a22a8895a678b32ca (patch)
tree778d8ab6318486d34ae952e0caafbe40ebc50319 /compiler/rustc_codegen_llvm/src/attributes.rs
parent1408715ab88cc51ba58bd344209f33e91bdb50d3 (diff)
parent54dc7cebce9e983a72ee06657e931ba34b373ea8 (diff)
downloadrust-69e1d22ddbc67b25141a735a22a8895a678b32ca.tar.gz
rust-69e1d22ddbc67b25141a735a22a8895a678b32ca.zip
Auto merge of #83981 - nagisa:nagisa/revert-cfg-wasm, r=Mark-Simulacrum
Remove the insta-stable `cfg(wasm)`

The addition of `cfg(wasm)` was an oversight on my end that turns out to have a number
of downsides:

* It was introduced as an insta-stable addition, forgoing the usual
  staging mechanism we use for potentially far-reaching changes;
* It is a breaking change for people who are using `--cfg wasm` either
  directly or via cargo for other purposes;
* It is not entirely clear if a bare `wasm` cfg is a right option or
  whether `wasm` family of targets are special enough to warrant
  special-casing these targets specifically.

As for the last point, there appears to be a fair amount of support for
reducing the boilerplate in specifying architectures from the same
family, while ignoring their pointer width. The suggested way forward
would be to propose such a change as a separate RFC as it is potentially
a quite contentious addition.

cc #83879 `@devsnek`
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/attributes.rs')
0 files changed, 0 insertions, 0 deletions