diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-08-07 20:28:18 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-07 20:28:18 +0200 |
| commit | 8f39b86a6ab3d206d2e518b3d4c17c5b3243a60b (patch) | |
| tree | 0d20e924b8f89c923f745aad4687cfd8ae1970cd /compiler/rustc_codegen_llvm/src/attributes.rs | |
| parent | e34229508a3885dfc429c6cd6c815bb94ad808d1 (diff) | |
| parent | 273c67db83caf0260956b87dd976a7727e4d2cd3 (diff) | |
| download | rust-8f39b86a6ab3d206d2e518b3d4c17c5b3243a60b.tar.gz rust-8f39b86a6ab3d206d2e518b3d4c17c5b3243a60b.zip | |
Rollup merge of #128679 - RalfJung:codegen-fn-attrs, r=nikic
codegen: better centralize function declaration attribute computation For some reason, the codegen backend has two functions that compute which attributes a function declaration gets: `apply_attrs_llfn` and `attributes::from_fn_attrs`. They are called in different places, on entirely different layers of abstraction. To me the code seems cleaner if we centralize this entirely in `apply_attrs_llfn`, so that's what this PR does.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/attributes.rs')
| -rw-r--r-- | compiler/rustc_codegen_llvm/src/attributes.rs | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/compiler/rustc_codegen_llvm/src/attributes.rs b/compiler/rustc_codegen_llvm/src/attributes.rs index 876f05c6277..fde95104093 100644 --- a/compiler/rustc_codegen_llvm/src/attributes.rs +++ b/compiler/rustc_codegen_llvm/src/attributes.rs @@ -324,9 +324,10 @@ fn create_alloc_family_attr(llcx: &llvm::Context) -> &llvm::Attribute { llvm::CreateAttrStringValue(llcx, "alloc-family", "__rust_alloc") } +/// Helper for `FnAbi::apply_attrs_llfn`: /// Composite function which sets LLVM attributes for function depending on its AST (`#[attribute]`) /// attributes. -pub fn from_fn_attrs<'ll, 'tcx>( +pub fn llfn_attrs_from_instance<'ll, 'tcx>( cx: &CodegenCx<'ll, 'tcx>, llfn: &'ll Value, instance: ty::Instance<'tcx>, |