diff options
| author | bors <bors@rust-lang.org> | 2022-04-22 22:12:32 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-04-22 22:12:32 +0000 |
| commit | c2b4c2dffaab572cc060e96e52ded4b108614b82 (patch) | |
| tree | e685604e471b86b9e3d737f6440a6c922a8c7844 /compiler/rustc_codegen_llvm/src/attributes.rs | |
| parent | f4ec0e7cff545e932ce30e39087b16687f0affa1 (diff) | |
| parent | c52539605818d5c00870e1e973e99e8220c4a888 (diff) | |
| download | rust-c2b4c2dffaab572cc060e96e52ded4b108614b82.tar.gz rust-c2b4c2dffaab572cc060e96e52ded4b108614b82.zip | |
Auto merge of #95739 - lqd:proc-macro-expansions, r=wesleywiser
self-profiler: record spans for proc-macro expansions
This PR is a follow-up to #95473, using the arg recorder feature from #95689:
- it adds support code to easily record spans in the event's arguments, when using `generic_activity_with_arg_recorder`.
- uses that to record the spans where proc-macro expansions happen in addition to their name.
As for the other 2 PRs, the goal here is to provide visibility into proc-macro expansion performance, so that users can diagnose which uses of proc-macros in their code could be causing compile time issues.
Some areas where I'd love feedback:
- [x] the API and names: the `SpannedEventArgRecorder` trait and its method, much like #95689 had the same question about the `EventArgRecorder` naming
- [x] we don't currently have a way to record the names of the event arguments, so should `record_arg_spanned` record the span as "location: {}" or similar ?
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/attributes.rs')
0 files changed, 0 insertions, 0 deletions