about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/back
diff options
context:
space:
mode:
authorbjorn3 <17426603+bjorn3@users.noreply.github.com>2022-06-18 17:55:24 +0000
committerbjorn3 <17426603+bjorn3@users.noreply.github.com>2022-06-19 12:56:31 +0000
commit7ff0df51024a96e91f41c3760b5676ebbdc7a2c0 (patch)
tree8edbf86c1312908227b499fb3e53a6edbfc9fcfc /compiler/rustc_codegen_llvm/src/back
parent43929a8a75d85ae3939a80703bdd827e81c51ba5 (diff)
downloadrust-7ff0df51024a96e91f41c3760b5676ebbdc7a2c0.tar.gz
rust-7ff0df51024a96e91f41c3760b5676ebbdc7a2c0.zip
Fix "Remove src_files and remove_file"
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/back')
-rw-r--r--compiler/rustc_codegen_llvm/src/back/archive.rs11
1 files changed, 6 insertions, 5 deletions
diff --git a/compiler/rustc_codegen_llvm/src/back/archive.rs b/compiler/rustc_codegen_llvm/src/back/archive.rs
index 455c38ffb32..1f4bfffaafe 100644
--- a/compiler/rustc_codegen_llvm/src/back/archive.rs
+++ b/compiler/rustc_codegen_llvm/src/back/archive.rs
@@ -97,13 +97,14 @@ impl<'a> ArchiveBuilder<'a> for LlvmArchiveBuilder<'a> {
 
     /// Combine the provided files, rlibs, and native libraries into a single
     /// `Archive`.
-    fn build(mut self) {
+    fn build(mut self) -> bool {
         let kind = self.llvm_archive_kind().unwrap_or_else(|kind| {
             self.sess.fatal(&format!("Don't know how to build archive of type: {}", kind))
         });
 
-        if let Err(e) = self.build_with_llvm(kind) {
-            self.sess.fatal(&format!("failed to build archive: {}", e));
+        match self.build_with_llvm(kind) {
+            Ok(any_members) => any_members,
+            Err(e) => self.sess.fatal(&format!("failed to build archive: {}", e)),
         }
     }
 
@@ -270,7 +271,7 @@ impl<'a> LlvmArchiveBuilder<'a> {
         kind.parse().map_err(|_| kind)
     }
 
-    fn build_with_llvm(&mut self, kind: ArchiveKind) -> io::Result<()> {
+    fn build_with_llvm(&mut self, kind: ArchiveKind) -> io::Result<bool> {
         let mut additions = mem::take(&mut self.additions);
         let mut strings = Vec::new();
         let mut members = Vec::new();
@@ -353,7 +354,7 @@ impl<'a> LlvmArchiveBuilder<'a> {
                 };
                 Err(io::Error::new(io::ErrorKind::Other, msg))
             } else {
-                Ok(())
+                Ok(!members.is_empty())
             };
             for member in members {
                 llvm::LLVMRustArchiveMemberFree(member);