about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/builder.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-09-12 20:48:09 +0000
committerbors <bors@rust-lang.org>2021-09-12 20:48:09 +0000
commit51e514c0fb4f9afcaae3b02dd9ccb93e15b30ef8 (patch)
tree5cc0a4eaf3c88e826459f84b2a623026feed2195 /compiler/rustc_codegen_llvm/src/builder.rs
parentd2dfb0eb8e30d188fb1731e540bc1b418bcd046d (diff)
parent5862a0004a65e32ea3a36d33c52e305cd75a69fe (diff)
downloadrust-51e514c0fb4f9afcaae3b02dd9ccb93e15b30ef8.tar.gz
rust-51e514c0fb4f9afcaae3b02dd9ccb93e15b30ef8.zip
Auto merge of #88759 - Amanieu:panic_in_drop, r=nagisa,eddyb
Add -Z panic-in-drop={unwind,abort} command-line option

This PR changes `Drop` to abort if an unwinding panic attempts to escape it, making the process abort instead. This has several benefits:
- The current behavior when unwinding out of `Drop` is very unintuitive and easy to miss: unwinding continues, but the remaining drops in scope are simply leaked.
- A lot of unsafe code doesn't expect drops to unwind, which can lead to unsoundness:
  - https://github.com/servo/rust-smallvec/issues/14
  - https://github.com/bluss/arrayvec/issues/3
- There is a code size and compilation time cost to this: LLVM needs to generate extra landing pads out of all calls in a drop implementation. This can compound when functions are inlined since unwinding will then continue on to process drops in the callee, which can itself unwind, etc.
  - Initial measurements show a 3% size reduction and up to 10% compilation time reduction on some crates (`syn`).

One thing to note about `-Z panic-in-drop=abort` is that *all* crates must be built with this option for it to be sound since it makes the compiler assume that dropping `Box<dyn Any>` will never unwind.

cc https://github.com/rust-lang/lang-team/issues/97
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/builder.rs')
0 files changed, 0 insertions, 0 deletions