diff options
| author | bors <bors@rust-lang.org> | 2023-11-30 00:10:11 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-11-30 00:10:11 +0000 |
| commit | c9c760fc206345d0d7b7b4d989e2d95cd63ce9c0 (patch) | |
| tree | 6e026621955d4682142d1f7258220eccd1a403e5 /compiler/rustc_codegen_llvm/src/builder.rs | |
| parent | 475f6f85a8dc0b4291dad30a743db8e940893e44 (diff) | |
| parent | b25fa9a8118254a32bbc7529d959a8e2ccaf3c20 (diff) | |
| download | rust-c9c760fc206345d0d7b7b4d989e2d95cd63ce9c0.tar.gz rust-c9c760fc206345d0d7b7b4d989e2d95cd63ce9c0.zip | |
Auto merge of #114499 - taiki-e:riscv-forced-atomics, r=Amanieu
Pass +forced-atomics feature for riscv32{i,im,imc}-unknown-none-elf
As said in https://github.com/rust-lang/rust/pull/98333#issuecomment-1666375293, `forced-atomics` target feature is also needed to enable atomic load/store on these targets (otherwise, libcalls are generated): https://godbolt.org/z/433qeG7vd
~~This PR is currently marked as a draft because:~~
- ~~`forced-atomics` target feature is currently broken (https://github.com/rust-lang/rust/issues/114153).~~ EDIT: Fixed
- ~~`forced-atomics` target feature has been added in LLVM 16 (https://github.com/llvm/llvm-project/commit/f5ed0cb217a9988f97b55f2ccb053bca7b41cc0c), but the current minimum LLVM version [is 15](https://github.com/rust-lang/rust/blob/90f0b24ad3e7fc0dc0e419c9da30d74629cd5736/src/bootstrap/llvm.rs#L557). In LLVM 15, the atomic load/store of these targets generates libcalls anyway.~~ EDIT: LLVM 15 has been dropped
Depending on the policy on the minimum LLVM version for these targets, this may be blocked until the minimum LLVM version is increased to 16.
r? `@Amanieu`
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/builder.rs')
0 files changed, 0 insertions, 0 deletions