diff options
| author | Rich Kadel <richkadel@google.com> | 2020-12-07 17:41:53 -0800 |
|---|---|---|
| committer | Rich Kadel <richkadel@google.com> | 2020-12-07 17:56:19 -0800 |
| commit | 95c268f64d71427b00b46fde8fbf499d380e9409 (patch) | |
| tree | a1b1f59b22bf6944a7cb50c634851e48f3425c22 /compiler/rustc_codegen_llvm/src/coverageinfo | |
| parent | b5ff9c3d052c2c3d5f26076362f38643f6e48680 (diff) | |
| download | rust-95c268f64d71427b00b46fde8fbf499d380e9409.tar.gz rust-95c268f64d71427b00b46fde8fbf499d380e9409.zip | |
Fixes to Rust coverage
Fixes: #79725 Some macros can create a situation where `fn_sig_span` and `body_span` map to different files. New documentation on coverage tests incorrectly assumed multiple test binaries could just be listed at the end of the `llvm-cov` command, but it turns out each binary needs a `--object` prefix. This PR fixes the bug and updates the documentation to correct that issue. It also fixes a few other minor issues in internal implementation comments, and adds documentation on getting coverage results for doc tests.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/coverageinfo')
| -rw-r--r-- | compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs b/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs index 1c7e727f9b0..72ba5bbd5f2 100644 --- a/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs +++ b/compiler/rustc_codegen_llvm/src/coverageinfo/mapgen.rs @@ -241,7 +241,7 @@ fn save_function_record( /// (functions referenced by other "used" or public items). Any other functions considered unused, /// or "Unreachable" were still parsed and processed through the MIR stage. /// -/// We can find the unreachable functions by the set different of all MIR `DefId`s (`tcx` query +/// We can find the unreachable functions by the set difference of all MIR `DefId`s (`tcx` query /// `mir_keys`) minus the codegenned `DefId`s (`tcx` query `collect_and_partition_mono_items`). /// /// *HOWEVER* the codegenned `DefId`s are partitioned across multiple `CodegenUnit`s (CGUs), and |