about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/debuginfo
diff options
context:
space:
mode:
authorMichael Woerister <michaelwoerister@posteo>2022-02-08 15:31:09 +0100
committerMichael Woerister <michaelwoerister@posteo>2022-02-08 15:31:09 +0100
commited21805aee9ad1abed5dc5157ac568e95fd84afb (patch)
tree9f6e9973e98e142c4ffb94cfe78a6122f49db55a /compiler/rustc_codegen_llvm/src/debuginfo
parentfc7f419a63e4c98a928729d0ad59c426ccb84963 (diff)
downloadrust-ed21805aee9ad1abed5dc5157ac568e95fd84afb.tar.gz
rust-ed21805aee9ad1abed5dc5157ac568e95fd84afb.zip
debuginfo: Bring back DW_AT_containing_type for vtables -- address review comments
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/debuginfo')
-rw-r--r--compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs4
1 files changed, 3 insertions, 1 deletions
diff --git a/compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs b/compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs
index c367e6ed670..da997dd9879 100644
--- a/compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs
+++ b/compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs
@@ -2662,11 +2662,13 @@ fn vtable_type_metadata<'ll, 'tcx>(
                 }
                 ty::VtblEntry::Method(_) => {
                     // Note: This code does not try to give a proper name to each method
-                    //       because their might be multiple methods with the same name
+                    //       because there might be multiple methods with the same name
                     //       (coming from different traits).
                     (format!("__method{}", index), void_pointer_type_debuginfo)
                 }
                 ty::VtblEntry::TraitVPtr(_) => {
+                    // Note: In the future we could try to set the type of this pointer
+                    //       to the type that we generate for the corresponding vtable.
                     (format!("__super_trait_ptr{}", index), void_pointer_type_debuginfo)
                 }
                 ty::VtblEntry::MetadataAlign => ("align".to_string(), usize_debuginfo),