diff options
| author | Wilfred Hughes <wilfred@meta.com> | 2024-09-05 12:36:38 -0700 |
|---|---|---|
| committer | Wilfred Hughes <wilfred@meta.com> | 2024-09-05 15:46:03 -0700 |
| commit | 06c86a106915b5875391a7abdd749f1708dc3b50 (patch) | |
| tree | 73e95611323a3aea55c4a4152b61d2097dacff22 /compiler/rustc_codegen_llvm/src/errors.rs | |
| parent | a3be86666893ab0b79e53c301f34fd29d9550447 (diff) | |
| download | rust-06c86a106915b5875391a7abdd749f1708dc3b50.tar.gz rust-06c86a106915b5875391a7abdd749f1708dc3b50.zip | |
fix: Updating settings should not clobber discovered projects
`linkedProjects` is owned by the user's configuration, so when users update this setting, `linkedProjects` is reset. This is problematic when `linkedProjects` also contains projects discovered with `discoverCommand`. The buggy behaviour occurred when: (1) The user configures `discoverCommand` and loads a Rust project. (2) The user changes any setting in VS Code, so rust-analyzer receives `workspace/didChangeConfiguration`. (3) `handle_did_change_configuration` ultimately calls `Client::apply_change_with_sink()`, which updates `config.user_config` and discards any items we added in `linkedProjects`. Instead, separate out `discovered_projects_from_filesystem` and `discovered_projects_from_command` from user configuration, so user settings cannot affect any type of discovered project. This fixes the subtle issue mentioned here: https://github.com/rust-lang/rust-analyzer/pull/17246#issuecomment-2185259122
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/errors.rs')
0 files changed, 0 insertions, 0 deletions