diff options
| author | bors <bors@rust-lang.org> | 2023-07-19 07:27:50 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-07-19 07:27:50 +0000 |
| commit | 77e24f90f599070af2d8051ef9adad7fe528dd78 (patch) | |
| tree | d5dc97aa3d249794d5835db939ac309fee5604be /compiler/rustc_codegen_llvm/src/errors.rs | |
| parent | b657dc555b1ecf837cc4ea471fbae6a731529d55 (diff) | |
| parent | c59b82353d70122b59f5bc428be9464f49a99326 (diff) | |
| download | rust-77e24f90f599070af2d8051ef9adad7fe528dd78.tar.gz rust-77e24f90f599070af2d8051ef9adad7fe528dd78.zip | |
Auto merge of #112591 - jfgoog:better-dlltool-diagnostics, r=WaffleLapkin
Better diagnostics for dlltool errors. When dlltool fails, show the full command that was executed. In particular, llvm-dlltool is not very helpful, printing a generic usage message rather than what actually went wrong, so stdout and stderr aren't of much use when troubleshooting.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/errors.rs')
| -rw-r--r-- | compiler/rustc_codegen_llvm/src/errors.rs | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/compiler/rustc_codegen_llvm/src/errors.rs b/compiler/rustc_codegen_llvm/src/errors.rs index 44869ced1ae..fced6d504d2 100644 --- a/compiler/rustc_codegen_llvm/src/errors.rs +++ b/compiler/rustc_codegen_llvm/src/errors.rs @@ -81,6 +81,8 @@ pub(crate) struct ErrorCallingDllTool<'a> { #[derive(Diagnostic)] #[diag(codegen_llvm_dlltool_fail_import_library)] pub(crate) struct DlltoolFailImportLibrary<'a> { + pub dlltool_path: Cow<'a, str>, + pub dlltool_args: String, pub stdout: Cow<'a, str>, pub stderr: Cow<'a, str>, } |