about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/errors.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2023-03-23 09:51:32 +0000
committerbors <bors@rust-lang.org>2023-03-23 09:51:32 +0000
commit9a6b0c3326f3577f330d8828d3b706c0eea9cf29 (patch)
tree9569e32141556b66313fd454efd9a794fc1b423a /compiler/rustc_codegen_llvm/src/errors.rs
parent84dd6dfd9d19176cc3c94bc1448a841e44d57890 (diff)
parenta90f342b033c14171916ae019b4dfbd0bb408908 (diff)
downloadrust-9a6b0c3326f3577f330d8828d3b706c0eea9cf29.tar.gz
rust-9a6b0c3326f3577f330d8828d3b706c0eea9cf29.zip
Auto merge of #108355 - dpaoliello:dlltoolm, r=michaelwoerister
Fix cross-compiling with dlltool for raw-dylib

Fix for #103939

Issue Details:
When attempting to cross-compile using the `raw-dylib` feature and the GNU toolchain, rustc would attempt to find a cross-compiling version of dlltool (e.g., `i686-w64-mingw32-dlltool`). The has two issues 1) on Windows dlltool is always `dlltool` (no cross-compiling named versions exist) and 2) it only supported compiling to i686 and x86_64 resulting in ARM 32 and 64 compiling as x86_64.

Fix Details:
* On Windows always use the normal `dlltool` binary.
* Add the ARM64 cross-compiling dlltool name (support for this is coming: https://sourceware.org/bugzilla/show_bug.cgi?id=29964)
* Provide the `-m` argument to dlltool to indicate the target machine type.

(This is the first of two PRs to fix the remaining issues for the `raw-dylib` feature (#58713) that is blocking stabilization (#104218))
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/errors.rs')
0 files changed, 0 insertions, 0 deletions