diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-07-25 16:48:17 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-25 16:48:17 +0200 |
| commit | ae71900ef6e68a8b497f9b5ab255977fcfb64d36 (patch) | |
| tree | cc8ebc8c49e9bc120b06311673dc4f1b872d7f33 /compiler/rustc_codegen_llvm/src/errors.rs | |
| parent | 54be9ad5eb47207d155904f6c912a9526133f75f (diff) | |
| parent | c5e1a12efc32b4e487a8899b143909e17d864adf (diff) | |
| download | rust-ae71900ef6e68a8b497f9b5ab255977fcfb64d36.tar.gz rust-ae71900ef6e68a8b497f9b5ab255977fcfb64d36.zip | |
Rollup merge of #121364 - Urgau:unary_precedence, r=compiler-errors
Implement lint against ambiguous negative literals This PR implements a lint against ambiguous negative literals with a literal and method calls right after it. ## `ambiguous_negative_literals` (deny-by-default) The `ambiguous_negative_literals` lint checks for cases that are confusing between a negative literal and a negation that's not part of the literal. ### Example ```rust,compile_fail -1i32.abs(); // equals -1, while `(-1i32).abs()` equals 1 ``` ### Explanation Method calls take precedence over unary precedence. Setting the precedence explicitly makes the code clearer and avoid potential bugs. <details> <summary>Old proposed lint</summary> ## `ambiguous_unary_precedence` (deny-by-default) The `ambiguous_unary_precedence` lint checks for use the negative unary operator with a literal and method calls. ### Example ```rust -1i32.abs(); // equals -1, while `(-1i32).abs()` equals 1 ``` ### Explanation Unary operations take precedence on binary operations and method calls take precedence over unary precedence. Setting the precedence explicitly makes the code clearer and avoid potential bugs. </details> ----- Note: This is a strip down version of https://github.com/rust-lang/rust/pull/117161, without the binary op precedence. Fixes https://github.com/rust-lang/rust/issues/117155 `@rustbot` labels +I-lang-nominated cc `@scottmcm` r? compiler
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/errors.rs')
0 files changed, 0 insertions, 0 deletions
