about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/errors.rs
diff options
context:
space:
mode:
authorJubilee Young <workingjubilee@gmail.com>2024-02-03 14:18:58 -0800
committerJubilee Young <workingjubilee@gmail.com>2024-02-17 14:31:42 -0800
commitba93b4972ff21e63a330003c6a4469315651155b (patch)
tree6172f9b632b738e6a30286ef55fa026199f60a81 /compiler/rustc_codegen_llvm/src/errors.rs
parenta416fdeb4f71988daed772b7a41d55598ea25077 (diff)
downloadrust-ba93b4972ff21e63a330003c6a4469315651155b.tar.gz
rust-ba93b4972ff21e63a330003c6a4469315651155b.zip
Suggest pattern in meaningful test diagnostic
As the reason for tidy failing the test name may seem slightly opaque,
provide a suggestion on how to rename the file.

There are some tests which merely would require reordering of the name
according to the rule. I could modify the diagnostic further to identify
those, but doing such would make it prone to bad suggestions. I have opted
to trust contributors to recognize the diagnostic is robotic, as the
pattern we are linting on is easier to match if we do not speculate on what
parts of the name are meaningful: sometimes a word is a reason, but
sometimes it is a mere "tag", such as with a pair like:

    issue-314159265-blue.rs
    issue-314159265-red.rs

Starting them with `red-` and `blue-` means they do not sort together,
despite being related, and the color names are still not very descriptive.
Recognizing a good name is an open-ended task, though this pair might be:

    colored-circle-gen-blue.rs
    colored-circle-gen-red.rs

Deciding exactly how to solve this is not the business of tidy,
only recognizing a what.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/errors.rs')
0 files changed, 0 insertions, 0 deletions