about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/errors.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-08-05 13:00:02 +0000
committerbors <bors@rust-lang.org>2024-08-05 13:00:02 +0000
commite611c8e1c4cc7c86cc95f4e646ff4322b8345fb3 (patch)
treed596794160dd400c690bc0aa211dd3b9a322b73f /compiler/rustc_codegen_llvm/src/errors.rs
parent7ac242c3d0d3ee867a6c9cdcbdec986c408ac36f (diff)
parent234ea1fcd91e2656b2e6b073022a6f6b95000fb0 (diff)
downloadrust-e611c8e1c4cc7c86cc95f4e646ff4322b8345fb3.tar.gz
rust-e611c8e1c4cc7c86cc95f4e646ff4322b8345fb3.zip
Auto merge of #13217 - dtolnay-contrib:toolsutil, r=flip1995
Check exit status of subcommands spawned by rustc_tools_util

The git commands `git rev-parse --short HEAD` and `git log -1 --date=short --pretty=format:%cd` that clippy runs from its build script might fail with **"fatal: not a git repository (or any of the parent directories): .git"** if clippy is being built from a source tarball rather than a git repository. That message is written by git to stderr, and nothing is written to stdout.

For `clippy-driver --version` this PR wouldn't make a difference because it treats empty stdout and failed spawns (`git` is not installed) identically:

https://github.com/rust-lang/rust-clippy/blob/7ac242c3d0d3ee867a6c9cdcbdec986c408ac36f/rustc_tools_util/src/lib.rs#L35-L42

But other users of `rustc_tools_util` should be able to expect that the distinction between Some and None is meaningful. They shouldn't need extra code to handle None vs Some-and-empty vs Some-and-nonempty.

---

changelog: none
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/errors.rs')
0 files changed, 0 insertions, 0 deletions