about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/errors.rs
diff options
context:
space:
mode:
authorjoboet <jonasboettiger@icloud.com>2024-06-15 17:47:35 +0200
committerjoboet <jonasboettiger@icloud.com>2024-06-15 17:47:35 +0200
commitf3facf11758af878bcfaf47fc773962dbb565024 (patch)
tree81d1238932f3d528e11dcb2e8857fc5a39587164 /compiler/rustc_codegen_llvm/src/errors.rs
parentd2ad293851dc8e14a61355d0358490b77efae8cb (diff)
downloadrust-f3facf11758af878bcfaf47fc773962dbb565024.tar.gz
rust-f3facf11758af878bcfaf47fc773962dbb565024.zip
std: refactor the TLS implementation
As discovered by Mara in #110897, our TLS implementation is a total mess. In the past months, I have simplified the actual macros and their expansions, but the majority of the complexity comes from the platform-specific support code needed to create keys and register destructors. In keeping with #117276, I have therefore moved all of the `thread_local_key`/`thread_local_dtor` modules to the `thread_local` module in `sys` and merged them into a new structure, so that future porters of `std` can simply mix-and-match the existing code instead of having to copy the same (bad) implementation everywhere. The new structure should become obvious when looking at `sys/thread_local/mod.rs`.

Unfortunately, the documentation changes associated with the refactoring have made this PR rather large. That said, this contains no functional changes except for two small ones:
* the key-based destructor fallback now, by virtue of sharing the implementation used by macOS and others, stores its list in a `#[thread_local]` static instead of in the key, eliminating one indirection layer and drastically simplifying its code.
* I've switched over ZKVM (tier 3) to use the same implementation as WebAssembly, as the implementation was just a way worse version of that

Please let me know if I can make this easier to review! I know these large PRs aren't optimal, but I couldn't think of any good intermediate steps.

@rustbot label +A-thread-locals
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/errors.rs')
0 files changed, 0 insertions, 0 deletions