about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/lib.rs
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2025-02-19 21:16:12 +0100
committerGitHub <noreply@github.com>2025-02-19 21:16:12 +0100
commit3964bb131b3b7a24f20803d8efe3bd1d76fc5abc (patch)
tree7c6b96ea3cb13b1739ffd57af16669d8968e9c5e /compiler/rustc_codegen_llvm/src/lib.rs
parentc29cc600fdc7f6c673242c340126dddfdb040413 (diff)
parent05e4175d79a7e8f2fc11c3d2ae70bb31a354f130 (diff)
downloadrust-3964bb131b3b7a24f20803d8efe3bd1d76fc5abc.tar.gz
rust-3964bb131b3b7a24f20803d8efe3bd1d76fc5abc.zip
Rollup merge of #137155 - thaliaarchi:wtf8-organize, r=ChrisDenton
Organize `OsString`/`OsStr` shims

Synchronize the `bytes.rs` and `wtf8.rs` shims for `OsString`/`OsStr` so they're easier to diff between each other. This is mostly ordering items the same between the two. I tried to minimize moves and went for the average locations between the files.

With them in the same order, it is clear that `FromInner<_>` is not implemented for `bytes::Buf` and `Clone::clone_from` is not implemented for `wtf8::Buf`, but they are for the other. Fix that.

I added #[inline] to all inherent methods of the `OsString`/`OsStr` shims, because it seemed that was already the rough pattern. `bytes.rs` has more inlining than `wtf8.rs`, so I added the corresponding ones to `wtf8.rs`. Then, the common missing ones have no discernible pattern to me. They're not divided by non-allocating/allocating. Perhaps the pattern is that UTF-8 validation isn't inlined? Since these types are merely the inner values in `OsStr`/`OsString`, I put inline on all methods and let those public types dictate inlining. I have not inspected codegen or run benchmarks.

Also, touch up some (private) documentation comments.

r? ``````@ChrisDenton``````
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/lib.rs')
0 files changed, 0 insertions, 0 deletions