diff options
| author | bors <bors@rust-lang.org> | 2020-11-22 01:09:04 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2020-11-22 01:09:04 +0000 |
| commit | 70090118c281ea7dba2e6093462d8ae0e1fa7195 (patch) | |
| tree | 4d00450fe6416fb42524aa73228d5de7188e50e5 /compiler/rustc_codegen_llvm/src/llvm/mod.rs | |
| parent | a1a13b2bc4fa6370b9501135d97c5fe0bc401894 (diff) | |
| parent | 25a3ffe5d4768e37fe98c9637db84af4714549d4 (diff) | |
| download | rust-70090118c281ea7dba2e6093462d8ae0e1fa7195.tar.gz rust-70090118c281ea7dba2e6093462d8ae0e1fa7195.zip | |
Auto merge of #78752 - jyn514:html-diff, r=GuillaumeGomez
Give a better error when rustdoc tests fail - Run the default rustdoc against the current rustdoc - Diff output recursively - Colorize diff output Closes https://github.com/rust-lang/rust/issues/78750. ## Resolved questions - Should this be opt-in instead of on by default? + No - Should this call through to `delta`? That's not a very common program to have installed, but I'm not sure how to do diffs after the fact. Maybe `compiletest` can take a `--syntax-highlighter` parameter or something? + I decided to use `delta` if available and `diff --color` otherwise. It prints a warning if delta isn't installed so you know you can get nicer diffs ## Open questions. - What version of rustdoc would this compare against? Ideally it would compare against `$(git merge-base HEAD origin/master)` - maybe that's feasible if we install those artifacts from CI? - Does it always make sense to compare the tests? Especially for new tests, I'm not sure how useful it would be ... but then again, one of the questions I want to know most as a reviewer is 'did it break before?'. r? `@GuillaumeGomez` cc `@Mark-Simulacrum`
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/llvm/mod.rs')
0 files changed, 0 insertions, 0 deletions