about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/llvm_util.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-09-19 01:38:17 +0000
committerbors <bors@rust-lang.org>2021-09-19 01:38:17 +0000
commit10967a1dcc9847a6fa616e58a788efdf32cadf98 (patch)
tree29637ca23c6b7675e49d55947b129d511299f6df /compiler/rustc_codegen_llvm/src/llvm_util.rs
parente20a4ec1340f538296b4c81c4b00ef8fa64b7350 (diff)
parentf1f1c8fa505b8b7e2cab75c30e6f7f8a62b5ca7a (diff)
downloadrust-10967a1dcc9847a6fa616e58a788efdf32cadf98.tar.gz
rust-10967a1dcc9847a6fa616e58a788efdf32cadf98.zip
Auto merge of #88968 - tmiasko:start-block-no-predecessors, r=davidtwco
Start block is not allowed to have basic block predecessors

* The MIR validator is extended to detect potential violations.
* The start block has no predecessors after building MIR, so no changes are required there.
* The SimplifyCfg could previously violate this requirement when collapsing goto chains, so transformation is disabled for the start block, which also substantially simplifies the implementation.
* The LLVM function entry block also must not have basic block predecessors. Previously, to ensure that code generation had to perform necessary adjustments. This now became unnecessary.

The motivation behind the change is to align with analogous requirement in LLVM, and to avoid potential latent bugs like the one reported in #88043.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/llvm_util.rs')
0 files changed, 0 insertions, 0 deletions