diff options
| author | bors <bors@rust-lang.org> | 2021-09-22 06:43:33 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2021-09-22 06:43:33 +0000 |
| commit | ce45663e14dac3f0f58be698cc530bc2e6e21682 (patch) | |
| tree | df12c759560d579029acad20d2df9bbf94178ede /compiler/rustc_codegen_llvm/src/llvm_util.rs | |
| parent | 77f4143fa26a1434088f532d2ba7ec51e0a392fd (diff) | |
| parent | 08e026675ee38bb4ca81106e766a6456c8b7382e (diff) | |
| download | rust-ce45663e14dac3f0f58be698cc530bc2e6e21682.tar.gz rust-ce45663e14dac3f0f58be698cc530bc2e6e21682.zip | |
Auto merge of #88865 - guswynn:must_not_suspend, r=oli-obk
Implement `#[must_not_suspend]` implements #83310 Some notes on the impl: 1. The code that searches for the attribute on the ADT is basically copied from the `must_use` lint. It's not shared, as the logic did diverge 2. The RFC does specify that the attribute can be placed on fn's (and fn-like objects), like `must_use`. I think this is a direct copy from the `must_use` reference definition. This implementation does NOT support this, as I felt that ADT's (+ `impl Trait` + `dyn Trait`) cover the usecase's people actually want on the RFC, and adding an imp for the fn call case would be significantly harder. The `must_use` impl can do a single check at fn call stmt time, but `must_not_suspend` would need to answer the question: "for some value X with type T, find any fn call that COULD have produced this value". That would require significant changes to `generator_interior.rs`, and I would need mentorship on that. `@eholk` and I are discussing it. 3. `@estebank` do you know a way I can make the user-provided `reason` note pop out? right now it seems quite hidden Also, I am not sure if we should run perf on this r? `@nikomatsakis`
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/llvm_util.rs')
0 files changed, 0 insertions, 0 deletions
