about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/llvm_util.rs
diff options
context:
space:
mode:
authorManish Goregaokar <manishsmail@gmail.com>2021-10-05 12:52:48 -0700
committerGitHub <noreply@github.com>2021-10-05 12:52:48 -0700
commitf71b3e2b46505fda8dea7187fa90b80472f7abfa (patch)
treefbf28a75f29d4f004795e4adf0a826fc81e01f30 /compiler/rustc_codegen_llvm/src/llvm_util.rs
parent048b0fd98df7ed3351e4c133eda4f683cb872956 (diff)
parent9f9f7f695a793c5ef27d219dbd00c66810f34e92 (diff)
downloadrust-f71b3e2b46505fda8dea7187fa90b80472f7abfa.tar.gz
rust-f71b3e2b46505fda8dea7187fa90b80472f7abfa.zip
Rollup merge of #89532 - ecstatic-morse:maybe-live-locals-enum, r=oli-obk,tmiasko
Document behavior of  `MaybeLiveLocals` regarding enums and field-senstivity

This arose from a [discussion on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/189540-t-compiler.2Fwg-mir-opt/topic/MaybeLiveLocals.20and.20Discriminants) where a new contributor attempted to implement a dead-store elimination pass using this analysis. They ran into a nasty hack around `SetDiscriminant` the effect of which is to lets handle assignments of literals to enum-typed locals (e.g. `x = Some(4)`) correctly. This took me a while to figure out.

Document this oddity, so the next person will have an easier time, and add a test to enshrine the current behavior.

r? ``@tmiasko``
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/llvm_util.rs')
0 files changed, 0 insertions, 0 deletions