about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorDylan DPC <99973273+Dylan-DPC@users.noreply.github.com>2022-06-29 10:28:23 +0530
committerGitHub <noreply@github.com>2022-06-29 10:28:23 +0530
commit021d21c88877bb8f5db8326ebfdb1baad64b1e70 (patch)
tree8f771af4019503b233c959d674df90929c23c353 /compiler/rustc_codegen_llvm/src
parentb8bb6f9a4bdd246891758612c98c5a11d5aad76b (diff)
parent852a111133c86b24b190d6f9b5e19f8864e954a2 (diff)
downloadrust-021d21c88877bb8f5db8326ebfdb1baad64b1e70.tar.gz
rust-021d21c88877bb8f5db8326ebfdb1baad64b1e70.zip
Rollup merge of #98549 - RalfJung:interpret-stacktraces, r=oli-obk
interpret: do not prune requires_caller_location stack frames quite so early

https://github.com/rust-lang/rust/pull/87000 made the interpreter skip `caller_location` frames for its stacktraces and `cur_span`. However, those functions are used for much more than just panic reporting, and e.g. when Miri reports UB somewhere, it probably wants to point inside `caller_location` frames. (And if it did not, it would want to have its own logic to decide that, not be forced into it by the core interpreter engine.) This fixes some rare ICEs in Miri that say "we should never pop more than one frame at once".

So let's remove all `caller_location` logic from the core interpreter, and instead move it to CTFE error reporting. This does not change user-visible behavior. That's the first commit.

We might additionally want to change CTFE error reporting to treat panics differently from other errors: only prune `caller_location` frames for panics. The second commit does that. But honestly I am not sure if this is an improvement.

r? ``@oli-obk``
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions