diff options
| author | bors <bors@rust-lang.org> | 2020-12-17 21:13:51 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2020-12-17 21:13:51 +0000 |
| commit | 1954756aa53d03e59e40669eaa47a15d8497c352 (patch) | |
| tree | c2ce5046320e43c9a95162e7a608c9658a29b870 /compiler/rustc_codegen_llvm/src | |
| parent | eb4fc71dc9024f15a0c9cc44bcc10c861e9d585e (diff) | |
| parent | 88dc58fc9bb3dddccb99fc0e9f7a917c2052f8d0 (diff) | |
| download | rust-1954756aa53d03e59e40669eaa47a15d8497c352.tar.gz rust-1954756aa53d03e59e40669eaa47a15d8497c352.zip | |
Auto merge of #80122 - davidtwco:revert-76030, r=oli-obk
Revert "cg_llvm: `fewer_names` in `uncached_llvm_type`" Fixes #76213 and fixes #79564. This PR temporarily reverts commit fa01ce802f1b403a2140fd945b43af86ec3998a1 from #76030 to until the root issue can be resolved. Requested [in t-compiler meeting](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.20meeting.5D.202020-12-17.20.2354818/near/220261541). *Note*: I was seeing some failing debuginfo-gdb tests locally but I wasn't sure if they were spurious.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
| -rw-r--r-- | compiler/rustc_codegen_llvm/src/type_of.rs | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/compiler/rustc_codegen_llvm/src/type_of.rs b/compiler/rustc_codegen_llvm/src/type_of.rs index 8ea4768f77d..0876907e119 100644 --- a/compiler/rustc_codegen_llvm/src/type_of.rs +++ b/compiler/rustc_codegen_llvm/src/type_of.rs @@ -40,9 +40,7 @@ fn uncached_llvm_type<'a, 'tcx>( // FIXME(eddyb) producing readable type names for trait objects can result // in problematically distinct types due to HRTB and subtyping (see #47638). // ty::Dynamic(..) | - ty::Adt(..) | ty::Closure(..) | ty::Foreign(..) | ty::Generator(..) | ty::Str - if !cx.sess().fewer_names() => - { + ty::Adt(..) | ty::Closure(..) | ty::Foreign(..) | ty::Generator(..) | ty::Str => { let mut name = with_no_trimmed_paths(|| layout.ty.to_string()); if let (&ty::Adt(def, _), &Variants::Single { index }) = (layout.ty.kind(), &layout.variants) @@ -58,12 +56,6 @@ fn uncached_llvm_type<'a, 'tcx>( } Some(name) } - ty::Adt(..) => { - // If `Some` is returned then a named struct is created in LLVM. Name collisions are - // avoided by LLVM (with increasing suffixes). If rustc doesn't generate names then that - // can improve perf. - Some(String::new()) - } _ => None, }; |
