diff options
| author | Manish Goregaokar <manishsmail@gmail.com> | 2022-11-18 17:48:17 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-18 17:48:17 -0500 |
| commit | 3181006d83ae9a7c64e8d83693b87259974f0bfd (patch) | |
| tree | 5170e8c046e01e6fac78bdcd289469919c4869b2 /compiler/rustc_codegen_llvm/src | |
| parent | 19efa2599c1d661816c17fcb8e52776748ddc72a (diff) | |
| parent | 2721e407373711d59906dd5114bb14bf405c2e9e (diff) | |
| download | rust-3181006d83ae9a7c64e8d83693b87259974f0bfd.tar.gz rust-3181006d83ae9a7c64e8d83693b87259974f0bfd.zip | |
Rollup merge of #104047 - crlf0710:icu_based_list_formatting, r=davidtwco
Diagnostics `icu4x` based list formatting. This adds a new kind of `DiagnosticArg` and add the ability to convert it to a `FluentValue::Custom`. When emitting fluent output, it makes use of `ListFormatter` from `icu4x` project to convert it to localized version of list following the fluent locale, as a kind of eager translation. Tested locally with locales like `en`, `ja`, etc, and they work fine. <del>Though neither `zh-CN` nor `zh-Hans` works correctly, it seems they fallback to `und` locale somehow, emitting only comma-based list. I believe this is an internal issue of `icu4x` itself.</del>(Works fine after https://github.com/rust-lang/rust/pull/104047#issuecomment-1304860940) Would love to hear what others think. r? `@davidtwco` cc `@Manishearth`
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions