about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-02-14 01:23:46 +0000
committerbors <bors@rust-lang.org>2024-02-14 01:23:46 +0000
commit37b65339c8cf1d18e331f184dbf70bbddcb1e4f7 (patch)
treec95decc6b714fb4fa448060f9764973a0496d808 /compiler/rustc_codegen_llvm/src
parenta84bb95a1f65bfe25038f188763a18e096a86ab2 (diff)
parent38df5bdcf1fee2dc4a7a566afee0f0f161417701 (diff)
downloadrust-37b65339c8cf1d18e331f184dbf70bbddcb1e4f7.tar.gz
rust-37b65339c8cf1d18e331f184dbf70bbddcb1e4f7.zip
Auto merge of #120942 - compiler-errors:deep-assoc-hang, r=lcnr
Ignore own item bounds in parent alias types in `for_each_item_bound`

Fixes #120912

I want to get a vibe check on this approach, which is very obviously a hack, but I believe something that is forwards-compatible with a more thorough solution and "good enough for now".

The problem here is that for a really deep rigid associated type, we are now repeatedly considering unrelated item bounds from the parent alias types, meaning we're doing a *lot* of extra work in the MIR inliner for deeply substituted rigid projections.

This feels intimately related to #107614. In that PR, we split *supertrait* bounds (bound which share the same `Self` type as the predicate which is being elaborated) and *implied* bounds (anything that is implied by elaborating the predicate).

The problem here is related to the fact that we don't maintain the split between these two for `item_bounds`. If we did, then when recursing into a parent alias type, we'd want to consider only the bounds that are given by [`PredicateFilter::All`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/astconv/enum.PredicateFilter.html#variant.SelfOnly) **except** those given by [`PredicateFilter::SelfOnly`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/astconv/enum.PredicateFilter.html#variant.SelfOnly).
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions