about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorAaron Hill <aa1ronham@gmail.com>2021-03-15 22:59:21 -0400
committerAaron Hill <aa1ronham@gmail.com>2021-03-18 12:09:14 -0400
commit390d1ef6d048563502458ae20d9b7d69d914a680 (patch)
tree42271bd5ced3243c0742afabdd2fdf067b5ec7e1 /compiler/rustc_codegen_llvm/src
parent0464f638af99a7c0876e9b8f96db5bbf917e3fe2 (diff)
downloadrust-390d1ef6d048563502458ae20d9b7d69d914a680.tar.gz
rust-390d1ef6d048563502458ae20d9b7d69d914a680.zip
Extend `proc_macro_back_compat` lint to `actix-web`
Unlike the other cases of this lint, there's no simple way to detect if
an old version of the relevant crate (`syn`) is in use. The `actix-web`
crate only depends on `pin-project` v1.0.0, so checking the version of
`actix-web` does not guarantee that a new enough version of
`pin-project` (and therefore `syn`) is in use.

Instead, we rely on the fact that virtually all of the regressed crates
are pinned to a pre-1.0 version of `pin-project`. When this is the case,
bumping the `actix-web` dependency will pull in the *latest* version of
`pin-project`, which has an explicit dependency on a newer v dependency
on a newer version of `syn`.

The lint message tells users to update `actix-web`, since that's what
they're most likely to have control over. We could potentially tell them
to run `cargo update -p syn`, but I think it's more straightforward to
suggest an explicit change to the `Cargo.toml`

The `actori-web` fork had its last commit over a year ago, and appears
to just be a renamed fork of `actix-web`. Therefore, I've removed the
`actori-web` check entirely - any crates that actually get broken can
simply update `syn` themselves.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions