about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorJubilee <workingjubilee@gmail.com>2024-10-24 15:53:34 -0700
committerGitHub <noreply@github.com>2024-10-24 15:53:34 -0700
commit3fea422be83f54f516eed5c2cd56d48621d2fc8d (patch)
tree75fa3e5ce2f14f6f9ad87e453bd7156fd5900cd0 /compiler/rustc_codegen_llvm/src
parenta0afe45466d321fb171dcaaf5dd33ff613b97112 (diff)
parent464b2425d810a97450bf2e45f39fc70b5203268c (diff)
downloadrust-3fea422be83f54f516eed5c2cd56d48621d2fc8d.tar.gz
rust-3fea422be83f54f516eed5c2cd56d48621d2fc8d.zip
Rollup merge of #132093 - jieyouxu:suppress-wer, r=onur-ozkan
compiletest: suppress Windows Error Reporting (WER) for `run-make` tests

WER by default will show a *bunch* of error dialogues for missing DLLs on Windows for `run-make` tests. We address that by:

1. Guarding `run-make` test process spawning with `disable_error_reporting`.
2. Fixing `disable_error_reporting` to also add the [`SEM_FAILCRITICALERRORS` flag to `SetErrorMode`][SetErrorMode]. Just `SEM_NOGPFAULTERRORBOX` was not sufficient to suppress error dialogues for e.g. missing DLLs.

Fixes #132092. In particular, refer to that issue for the necessary conditions to observe these dialogues from popping up in the first place.

I was only able to manually test this locally in my "native" Windows msvc environment and it prevents the WER dialogues from popping up, I don't think it's possible to really test this automatically.

[SetErrorMode]: https://learn.microsoft.com/en-us/windows/win32/api/errhandlingapi/nf-errhandlingapi-seterrormode?redirectedfrom=MSDN#parameters
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions