about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorAaron Hill <aa1ronham@gmail.com>2021-12-24 16:36:33 -0500
committerAaron Hill <aa1ronham@gmail.com>2022-01-05 10:13:28 -0500
commit5580e5e1dda4557bdbda14cdb4255a3e6facfe86 (patch)
treeeefcdd83dd525a4b1596e727b046c7308ac817e4 /compiler/rustc_codegen_llvm/src
parent936ce3dab7fd042101767c439362310f8355e859 (diff)
downloadrust-5580e5e1dda4557bdbda14cdb4255a3e6facfe86.tar.gz
rust-5580e5e1dda4557bdbda14cdb4255a3e6facfe86.zip
Ensure that `Fingerprint` caching respects hashing configuration
Fixes #92266

In some `HashStable` impls, we use a cache to avoid re-computing
the same `Fingerprint` from the same structure (e.g. an `AdtDef`).
However, the `StableHashingContext` used can be configured to
perform hashing in different ways (e.g. skipping `Span`s). This
configuration information is not included in the cache key,
which will cause an incorrect `Fingerprint` to be used if
we hash the same structure with different `StableHashingContext`
settings.

To fix this, the configuration settings of `StableHashingContext`
are split out into a separate `HashingControls` struct. This
struct is used as part of the cache key, ensuring that our caches
always produce the correct result for the given settings.

With this in place, we now turn off `Span` hashing during the
entire process of computing the hash included in legacy symbols.
This current has no effect, but will matter when a future PR
starts hashing more `Span`s that we currently skip.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions