about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorLéo Lanteri Thauvin <leseulartichaut@gmail.com>2021-08-25 15:49:00 +0200
committerGitHub <noreply@github.com>2021-08-25 15:49:00 +0200
commit82ecb0f412be53affb240cd1b356488218d1adca (patch)
tree2afa78961e39f0302c1e5d07d8b928e017655a3e /compiler/rustc_codegen_llvm/src
parent0aabf4bb4b74e9c7dd2c6164f362940dd6e5bf44 (diff)
parent7b5c0ecb3d902149fd6caa1d673ad5f7751320f3 (diff)
downloadrust-82ecb0f412be53affb240cd1b356488218d1adca.tar.gz
rust-82ecb0f412be53affb240cd1b356488218d1adca.zip
Rollup merge of #88298 - ijackson:errorkind-reorder, r=dtolnay
Errorkind reorder

I was doing a bit more work in this area and the untidiness of these two orderings bothered me.

The commit messages have the detailed rationale.  For your convenience, I c&p them here:

```
    io::ErrorKind: rationalise ordering in main enum

    It is useful to keep some coherent structure to this ordering.  In
    particular, Other and Uncategorized should be next to each other, at
    the end.

    Also it seems to make sense to treat UnexpectedEof and OutOfMemory
    specially, since they are not like the other errors (despite
    OutOfMemory also being generatable by some OS errors).

    So:
     * Move Other to the end, just before Uncategorized
     * Move Unsupported to between Interrupted and UnexpectedEof
     * Add some comments documenting where to add things
```

```
    io::Error: alphabeticise the match in as_str()

    There was no rationale for the previous ordering.
```

r? kennytm   since that's who rust-highfive picked before, in #88294 which I accidentally closed.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions