about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorEsteban Küber <esteban@kuber.com.ar>2024-02-14 17:48:40 +0000
committerEsteban Küber <esteban@kuber.com.ar>2024-02-16 04:28:05 +0000
commit9b3fcf9ad44faa6362be348ef233bbc81d128308 (patch)
treef473d45832c661bd6d4f8d2a2949ee7fdca74ef3 /compiler/rustc_codegen_llvm/src
parent0f806a9812b62c36bdab08d33c14cf2d3ecf4355 (diff)
downloadrust-9b3fcf9ad44faa6362be348ef233bbc81d128308.tar.gz
rust-9b3fcf9ad44faa6362be348ef233bbc81d128308.zip
Detect when method call on argument could be removed to fulfill failed trait bound
When encountering

```rust
struct Foo;
struct Bar;
impl From<Bar> for Foo {
    fn from(_: Bar) -> Self { Foo }
}
fn qux(_: impl From<Bar>) {}
fn main() {
    qux(Bar.into());
}
```

Suggest removing `.into()`:

```
error[E0283]: type annotations needed
 --> f100.rs:8:13
  |
8 |     qux(Bar.into());
  |     ---     ^^^^
  |     |
  |     required by a bound introduced by this call
  |
  = note: cannot satisfy `_: From<Bar>`
note: required by a bound in `qux`
 --> f100.rs:6:16
  |
6 | fn qux(_: impl From<Bar>) {}
  |                ^^^^^^^^^ required by this bound in `qux`
help: try using a fully qualified path to specify the expected types
  |
8 |     qux(<Bar as Into<T>>::into(Bar));
  |         +++++++++++++++++++++++   ~
help: consider removing this method call, as the receiver has type `Bar` and `Bar: From<Bar>` can be fulfilled
  |
8 -     qux(Bar.into());
8 +     qux(Bar);
  |
```

Fix #71252
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions