diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2024-04-21 13:30:25 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-21 13:30:25 +0200 |
| commit | 9efd1477ac2fbe4beb2b062771dae30e10d44ce8 (patch) | |
| tree | ebd22dad39c8edfc419a67ff4d530511291de6eb /compiler/rustc_codegen_llvm/src | |
| parent | f122a5129c465f76b30ce8f3c0aa533cea650f32 (diff) | |
| parent | fa53b9f39c23647ab25b416b1fa005e7dc7386ce (diff) | |
| download | rust-9efd1477ac2fbe4beb2b062771dae30e10d44ce8.tar.gz rust-9efd1477ac2fbe4beb2b062771dae30e10d44ce8.zip | |
Rollup merge of #124089 - simlay:fix-preadv64-and-pwritev64-link-for-watchos-and-visionos, r=workingjubilee
Fix watchOS and visionOS for pread64 and pwrite64 calls
In #122880, links to `preadv64` and `pwritev64` were added for `watchOS` however the underlying [`weak!` macro did not include `target_os = "watchos"`](https://github.com/rust-lang/rust/blob/c45dee5efd0c042e9d1e24559ebd0d6424d8aa70/library/std/src/sys/pal/unix/weak.rs#L30-L74).
This resulted in an `xcodebuild` error when targeting `watchOS`:
```
Undefined symbols for architecture arm64:
"_preadv64", referenced from:
__rust_extern_with_linkage_preadv64 in libliveview_native_core.a[274](std-324fdd8d31e8eaa2.std.e18cf7e8d0336778-cgu.08.rcgu.o)
"_pwritev64", referenced from:
__rust_extern_with_linkage_pwritev64 in libliveview_native_core.a[274](std-324fdd8d31e8eaa2.std.e18cf7e8d0336778-cgu.08.rcgu.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
So I added them. I also went ahead and added the same for visionOS because it's bound to create the same issue.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions
