about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2020-11-07 16:54:23 +0000
committerbors <bors@rust-lang.org>2020-11-07 16:54:23 +0000
commitb2d115f6db5172c961dfeb50de15f35784dbc7c9 (patch)
treee83547f8680c3223ba4429f628a3231165661c8c /compiler/rustc_codegen_llvm/src
parent0256d065d4901b63def6c04013da4f781d0752bb (diff)
parent3ca882986b31a801820a757dec0a89256804c0a7 (diff)
downloadrust-b2d115f6db5172c961dfeb50de15f35784dbc7c9.tar.gz
rust-b2d115f6db5172c961dfeb50de15f35784dbc7c9.zip
Auto merge of #75199 - Mark-Simulacrum:debug-asserts, r=pietroalbini
Re-enable debug and LLVM assertions

Historically we've disabled these assertions on a number of platforms with the
goal of speeding up CI. Now, though, having migrated to GitHub actions, CI is
already pretty fast, and these debug assertions do bring us some value.

This does leave in some debug assertions that are performance-related: macOS
currently hovers at just under 2 hours.

There are also some other builders which have debug and LLVM assertions
disabled:

llvm-8, PR builder:

In one view, this builder tests our support for older LLVMs. But in reality, a
lot of our tests already disable themselves on older LLVMs, and I think our
general stance is that we really only support the in-tree LLVM. Plus, we really
want CI times on this builder to be really low, as it's run on *every* PR --
that's a lot of CI time.

test-various:

This disables debug asserts still -- as noted in the Dockerfile, we test code
size, and we need debug asserts off for that to work well.

Helps with #59637 -- but doesn't close it, macOS still has asserts off.

r? `@pietroalbini`
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions