about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-05-03 10:56:15 +0000
committerbors <bors@rust-lang.org>2021-05-03 10:56:15 +0000
commitc825bc431ee5b815847b9bab693c59c43986fc4b (patch)
treecf73ba71c11ff4aafcc88db6efb49209cf564cbf /compiler/rustc_codegen_llvm/src
parente327a823d8b64e294e490efeca7829f383aa119d (diff)
parent1443c7646d37eb69c434268ec8b27cd0cf82d9f2 (diff)
downloadrust-c825bc431ee5b815847b9bab693c59c43986fc4b.tar.gz
rust-c825bc431ee5b815847b9bab693c59c43986fc4b.zip
Auto merge of #83312 - petrochenkov:noinner, r=Aaron1011
parser: Remove support for inner attributes on non-block expressions

Remove support for attributes like
```rust
fn attrs() {
    (#![print_target_and_args(fifth)] 1, 2);

    [#![print_target_and_args(sixth)] 1 , 2];
    [#![print_target_and_args(seventh)] true ; 5];

    match 0 {
        #![print_target_and_args(eighth)]
        _ => {}
    }

    MyStruct { #![print_target_and_args(ninth)] field: true };
}
```
They are
- useless
- unstable (modulo holes like https://github.com/rust-lang/rust/issues/65860)
- pessimize compiler performance, namely token collection for macros (cc https://github.com/rust-lang/rust/pull/82608)

I still want to run crater on this to check whether the stability holes are exploited in practice, and whether such attributes are used at all.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions