about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2024-05-31 17:05:27 +0200
committerGitHub <noreply@github.com>2024-05-31 17:05:27 +0200
commitdf9cd1700d5460c923b7915ec8db6e3e1618f32b (patch)
tree4247c2e818e0681dbfb865479bd017172b70b6c7 /compiler/rustc_codegen_llvm/src
parent619b3e8d4ef5d21119e33ca0f51f5df149d09b1a (diff)
parent54b6849e06cc4847625cdf6a7312eb017786867f (diff)
downloadrust-df9cd1700d5460c923b7915ec8db6e3e1618f32b.tar.gz
rust-df9cd1700d5460c923b7915ec8db6e3e1618f32b.zip
Rollup merge of #125816 - Zalathar:demangler, r=oli-obk
Don't build the `rust-demangler` binary for coverage tests

The coverage-run tests invoke `llvm-cov`, which requires us to specify a command-line demangler that it can use to demangle Rust symbol names.

Historically this used `src/tools/rust-demangler`, which means that we currently build two different command-line tools to help with the coverage tests (`rust-demangler` and `coverage-dump`).

However, it occurred to me that if we add a demangler mode to `coverage-dump` (which is only a handful of lines and no extra dependencies), then we only need to build one helper binary for the coverage tests, and there is no need for tests to build `rust-demangler` at all.

---

Note that the `rust-demangler` binary is separate from the `rustc-demangle` crate (which both `rust-demangler` and `coverage-dump` use as a dependency to do the actual demangling).

---

So the main benefits/motivations here are:
- Slightly faster builds after a fresh checkout or bootstrap bump.
- Making it clear that currently no tests actually need the `rust-demangler` binary, since the coverage tests can use their own tool instead.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions