diff options
| author | Trevor Gross <t.gross35@gmail.com> | 2024-07-27 13:32:57 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-27 13:32:57 -0400 |
| commit | ee25d992998cff9b067ce6a63ead16e7b3112bf7 (patch) | |
| tree | f5242fa0ae8df49871b67cb36fa9ec9321f88095 /compiler/rustc_codegen_llvm/src | |
| parent | 9164dbd48c7d5ca051d665bd30470ceda79d8849 (diff) | |
| parent | e7eae5370e304fb1534c1964852a6c127f1f09f8 (diff) | |
| download | rust-ee25d992998cff9b067ce6a63ead16e7b3112bf7.tar.gz rust-ee25d992998cff9b067ce6a63ead16e7b3112bf7.zip | |
Rollup merge of #128241 - compiler-errors:clone-sugg, r=jieyouxu
Remove logic to suggest clone of function output I can't exactly tell, but I believe that this suggestion is operating off of a heuristic that the lifetime of a function's input is correlated with the lifetime of a function's output in such a way that cloning would fix an error. I don't think that actually manages to hit the bar of "actually provides useful suggestions" most of the time. Specifically, I've hit false-positives due to this suggestion *twice* when fixing ICEs in the compiler, so I don't think it's worthwhile having this logic around. Neither of the two affected UI tests are actually fixed by the suggestion.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions