diff options
| author | bors <bors@rust-lang.org> | 2021-09-27 09:00:31 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2021-09-27 09:00:31 +0000 |
| commit | f100159f8cc4809e8820c85ca013ec8d061a02ca (patch) | |
| tree | b67aa8e75f1f6c1b299a4291a1138669581ff552 /compiler/rustc_codegen_llvm/src | |
| parent | 30fe4ba1fb58c5f929dcf0f637b400a1ceb77693 (diff) | |
| parent | 3ad3c51cee1d36d01fd145d6a45e33cff2bc12a1 (diff) | |
| download | rust-f100159f8cc4809e8820c85ca013ec8d061a02ca.tar.gz rust-f100159f8cc4809e8820c85ca013ec8d061a02ca.zip | |
Auto merge of #7692 - workingjubilee:float-cmp-not-wrong, r=giraffate
Demote float_cmp to pedantic See this issue: https://github.com/rust-lang/rust-clippy/issues/7666 This is one of the most frequently suppressed lints. It is deny-by-default. It is not actually clearly wrong, as there are many instances where direct float comparison is actually desirable. It is only after operating on floats that they may lose precision, and that depends greatly on the operation. As most correctness lints have a much higher standard of error, being based on hard and fast binary logic, this should not be amongst them. A linter is not a substitute for observing the math carefully and running tests, and doing the desirable thing is even more likely to lead one to want exact comparisons. changelog: Demote [`float_cmp`] from correctness to pedantic lints
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions