about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-05-01 00:04:36 +0000
committerbors <bors@rust-lang.org>2024-05-01 00:04:36 +0000
commitf5355b93ba43e5fbc44e8df5c113116844c43724 (patch)
tree00dc9f9bbb6c98fec9e1bcf439f610b05ac2ebd9 /compiler/rustc_codegen_llvm/src
parentf705de59625bb76067a5d102edc1575ff23b8845 (diff)
parent2a1d748254d3241967cf7d2bad141a371ccc7c99 (diff)
downloadrust-f5355b93ba43e5fbc44e8df5c113116844c43724.tar.gz
rust-f5355b93ba43e5fbc44e8df5c113116844c43724.zip
Auto merge of #124356 - fmease:fewer-magic-numbers-in-names, r=lcnr
Cleanup: Replace item names referencing GitHub issues or error codes with something more meaningful

**lcnr** in https://github.com/rust-lang/rust/pull/117164#pullrequestreview-1969935387:

> […] while I know that there's precendent to name things `Issue69420`, I really dislike this as it requires looking up the issue to figure out the purpose of such a variant. Actually referring to the underlying issue, e.g. `AliasMayNormToUncovered` or whatever and then linking to the issue in a doc comment feels a lot more desirable to me. We should ideally rename all the functions and enums which currently use issue numbers.

I've grepped through `compiler/` like crazy and think that I've found all instances of this pattern.
However, I haven't renamed `compute_2229_migrations_*`. Should I?

The first commit introduces an abhorrent and super long name for an item because naming is hard but also scary looking / unwelcoming names are good for things related to temporary-ish backcompat hacks. I'll let you discover it by yourself.

Contains a bit of drive-by cleanup and a diag migration bc that was the simplest option.

r? lcnr or compiler
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions