diff options
| author | Jubilee <workingjubilee@gmail.com> | 2024-10-07 11:10:54 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-07 11:10:54 -0700 |
| commit | f88bfa34e1c64758b6e3b37014282c929caecccb (patch) | |
| tree | 6669f7c1f3af7fc84d4ab22661795df9c6fe2cce /compiler/rustc_codegen_llvm/src | |
| parent | 9c4732a77d4fd77c73fc65db7fc46ce2a8e9deed (diff) | |
| parent | fa3c25e1124d4cd45efde79efdd7455e48379eda (diff) | |
| download | rust-f88bfa34e1c64758b6e3b37014282c929caecccb.tar.gz rust-f88bfa34e1c64758b6e3b37014282c929caecccb.zip | |
Rollup merge of #131351 - jieyouxu:yeet-the-valgrind, r=Kobzol
Remove valgrind test suite and support from compiletest, bootstrap and opt-dist The `run-pass-valgrind` test suite is not exercised in CI, and as far as I'm aware nobody runs it (asked in https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Are.20the.20valgrind.20tests.20even.20used.20by.20anyone.3F). What's remaining of valgrind support in compiletest isn't even properly hooked up with bootstrap. The existing valgrind logic in compiletest is also straight up questionable, i.e. https://github.com/rust-lang/rust/blob/1b3b8e7b0265162853c650ead09905bc3cdaeae9/src/tools/compiletest/src/runtest/valgrind.rs#L7-L12 It just runs valgrind tests as `rpass` if no valgrind path is provided to compiletest from bootstrap -- but bootstrap doesn't even pass a valgrind path to compiletest in the first place, so this always ran as `rpass` tests. So what is this even testing? So if it's not testing anything, let's delete it. Closes #44816 by deleting the test suite :3 <img src="https://github.com/user-attachments/assets/99525bf7-e85b-40ba-9281-e4e1e275c4e8" width=300 />
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions