about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorRich Kadel <richkadel@google.com>2021-04-01 12:25:45 -0700
committerRich Kadel <richkadel@google.com>2021-04-02 00:20:10 -0700
commitfad53880394f0cb4a8e2367fcc218c1fa55539d6 (patch)
treee85d3e03e866700be124d83a4d00272b3f2a6975 /compiler/rustc_codegen_llvm/src
parent4fa76a4a7742bb9c1febe33019f5a9e7e4839a65 (diff)
downloadrust-fad53880394f0cb4a8e2367fcc218c1fa55539d6.tar.gz
rust-fad53880394f0cb4a8e2367fcc218c1fa55539d6.zip
Simplify coverage tests
This change reduces the risk of impacting coverage tests on unrelated
changes (such as MIR and Span changes), and reduces the burden when
blessing coverage changes in case it is necessary.

* Remove all spanview tests. The spanview tests were useful during
  development, but they can be generated as needed, via compiler command
  line flags. They aren't critical to confirming coverage results. (The
  coverage report tests are sufficient.)

  When spanview regeneration was necessary, the diffs were way too hard
  to read to be useful anyway. So I'm removing them to reduce friction
  from a feature that is no longer useful.

* Remove the requirement for `llvm-cov show --debug` when blessing
  tests. The `--debug` flag is, unfortunately, only available if LLVM is
  built with `optimize = false` (in Rust's config.toml). This adds
  significant time and resource burdens to the contributor's build. As
  it turns out, for other reasons in the past, I wasn't actually using
  the debug output (counter info) to validate coverage anymore either,
  so it was required for no reason, I now realize.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions