diff options
| author | David Knaack <davidkna@users.noreply.github.com> | 2022-06-08 11:42:37 +0200 |
|---|---|---|
| committer | David Knaack <davidkna@users.noreply.github.com> | 2022-06-11 13:20:17 +0200 |
| commit | 8558b352955b39267b1663de3c4867a6092d6099 (patch) | |
| tree | a5a03354969c172c984f53b3de141e498ce2c2eb /compiler/rustc_codegen_ssa/src | |
| parent | 7092d42c04a56378d2e748f98169b728b1f1d5d1 (diff) | |
| download | rust-8558b352955b39267b1663de3c4867a6092d6099.tar.gz rust-8558b352955b39267b1663de3c4867a6092d6099.zip | |
Use safer `strip=symbols`-flag for dylibs on macOS
Diffstat (limited to 'compiler/rustc_codegen_ssa/src')
| -rw-r--r-- | compiler/rustc_codegen_ssa/src/back/link.rs | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/compiler/rustc_codegen_ssa/src/back/link.rs b/compiler/rustc_codegen_ssa/src/back/link.rs index 1f5e2b76bf0..82213e7d748 100644 --- a/compiler/rustc_codegen_ssa/src/back/link.rs +++ b/compiler/rustc_codegen_ssa/src/back/link.rs @@ -1003,10 +1003,14 @@ fn link_natively<'a, B: ArchiveBuilder<'a>>( let strip = strip_value(sess); if sess.target.is_like_osx { - match strip { - Strip::Debuginfo => strip_symbols_in_osx(sess, &out_filename, Some("-S")), - Strip::Symbols => strip_symbols_in_osx(sess, &out_filename, None), - Strip::None => {} + match (strip, crate_type) { + (Strip::Debuginfo, _) => strip_symbols_in_osx(sess, &out_filename, Some("-S")), + // Per the manpage, `-x` is the maximum safe strip level for dynamic libraries. (#93988) + (Strip::Symbols, CrateType::Dylib | CrateType::Cdylib | CrateType::ProcMacro) => { + strip_symbols_in_osx(sess, &out_filename, Some("-x")) + } + (Strip::Symbols, _) => strip_symbols_in_osx(sess, &out_filename, None), + (Strip::None, _) => {} } } } |