diff options
| author | Rich Kadel <richkadel@google.com> | 2020-08-27 12:53:43 -0700 |
|---|---|---|
| committer | Rich Kadel <richkadel@google.com> | 2020-08-31 18:41:13 -0700 |
| commit | ddb054aee898dd74261fa8f50fe0c6541e5ceaf3 (patch) | |
| tree | a5d8f94dec6ae400ecebc76c50eae8b992152642 /compiler/rustc_codegen_ssa/src | |
| parent | 85fbf49ce0e2274d0acf798f6e703747674feec3 (diff) | |
| download | rust-ddb054aee898dd74261fa8f50fe0c6541e5ceaf3.tar.gz rust-ddb054aee898dd74261fa8f50fe0c6541e5ceaf3.zip | |
Fix `-Z instrument-coverage` on MSVC
Found that -C link-dead-code (which was enabled automatically under -Z instrument-coverage) was causing the linking error that resulted in segmentation faults in coverage instrumented binaries. Link dead code is now disabled under MSVC, allowing `-Z instrument-coverage` to be enabled under MSVC for the first time. More details are included in Issue #76038. (This PR was broken out from PR #75828)
Diffstat (limited to 'compiler/rustc_codegen_ssa/src')
| -rw-r--r-- | compiler/rustc_codegen_ssa/src/back/link.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/rustc_codegen_ssa/src/back/link.rs b/compiler/rustc_codegen_ssa/src/back/link.rs index bfcf979d125..270c8250e19 100644 --- a/compiler/rustc_codegen_ssa/src/back/link.rs +++ b/compiler/rustc_codegen_ssa/src/back/link.rs @@ -1668,7 +1668,7 @@ fn linker_with_args<'a, B: ArchiveBuilder<'a>>( // FIXME: Order dependent, applies to the following objects. Where should it be placed? // Try to strip as much out of the generated object by removing unused // sections if possible. See more comments in linker.rs - if sess.opts.cg.link_dead_code != Some(true) { + if !sess.link_dead_code() { let keep_metadata = crate_type == CrateType::Dylib; cmd.gc_sections(keep_metadata); } |