diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-08-09 18:25:00 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-09 18:25:00 +0200 |
| commit | 665a1a4b55560ceb61d77a4c2e2e52ea5cd63b53 (patch) | |
| tree | ece7979bec4d7a3129e0de6454b63fd45a9fc096 /compiler/rustc_const_eval/src | |
| parent | 9eb77ac3e06d54aa94789982d8df499f649d6bc1 (diff) | |
| parent | d65f1316bba2b3cdccce3f0d7d3e2eb27b5fbe49 (diff) | |
| download | rust-665a1a4b55560ceb61d77a4c2e2e52ea5cd63b53.tar.gz rust-665a1a4b55560ceb61d77a4c2e2e52ea5cd63b53.zip | |
Rollup merge of #128865 - jieyouxu:unicurd, r=Urgau
Ensure let stmt compound assignment removal suggestion respect codepoint boundaries Previously we would try to issue a suggestion for `let x <op>= 1`, i.e. a compound assignment within a `let` binding, to remove the `<op>`. The suggestion code unfortunately incorrectly assumed that the `<op>` is an exactly-1-byte ASCII character, but this assumption is incorrect because we also recover Unicode-confusables like `➖=` as `-=`. In this example, the suggestion code used a `+ BytePos(1)` to calculate the span of the `<op>` codepoint that looks like `-` but the mult-byte Unicode look-alike would cause the suggested removal span to be inside a multi-byte codepoint boundary, triggering a codepoint boundary assertion. The fix is to use `SourceMap::start_point(token_span)` which properly accounts for codepoint boundaries. Fixes #128845. cc #128790 r? ````@fmease````
Diffstat (limited to 'compiler/rustc_const_eval/src')
0 files changed, 0 insertions, 0 deletions
