about summary refs log tree commit diff
path: root/compiler/rustc_const_eval/src
diff options
context:
space:
mode:
authorMatthias Krüger <476013+matthiaskrgr@users.noreply.github.com>2025-03-19 16:52:56 +0100
committerGitHub <noreply@github.com>2025-03-19 16:52:56 +0100
commitc3f74bcb39849b10c8b336db18530c79d7cb8701 (patch)
treee50da18a5ccf7863256fc0f876ae75b55b7db1ee /compiler/rustc_const_eval/src
parent2df731d586319ec9a90676fcf7eca43ca60825c5 (diff)
parentf478853f425fc0207add653b48c49c937acaa94e (diff)
downloadrust-c3f74bcb39849b10c8b336db18530c79d7cb8701.tar.gz
rust-c3f74bcb39849b10c8b336db18530c79d7cb8701.zip
Rollup merge of #138589 - zachs18:block-label-not-supported-here-loop-body-help, r=petrochenkov
If a label is placed on the block of a loop instead of the header, suggest moving it to the header.

Fixes #138585

If a label is placed on the block of a loop instead of the header, suggest to the user moving it to the loop header instead of ~~suggesting to remove it~~ emitting a tool-only suggestion to remove it.

```rs
fn main() {
    loop 'a: { return; }
}
```

```diff
 error: block label not supported here
  --> src/main.rs:2:10
   |
 2 |     loop 'a: { return; }
   |          ^^^ not supported here
+  |
+help: if you meant to label the loop, move this label before the loop
+  |
+2 -     loop 'a: { return; }
+2 +     'a: loop { return; }
+  |
```

Questions for reviewer:

* The "desired output" in the linked issue had the main diagnostic be "misplaced loop label". Should the main diagnostic message the changed instead of leaving it as "block label not supported here"?
* Should this be `Applicability::MachineApplicable`?
Diffstat (limited to 'compiler/rustc_const_eval/src')
0 files changed, 0 insertions, 0 deletions