diff options
| author | Ralf Jung <post@ralfj.de> | 2024-01-26 10:30:46 +0100 |
|---|---|---|
| committer | Ralf Jung <post@ralfj.de> | 2024-01-26 10:40:29 +0100 |
| commit | 64cd13ff3b9b5ca0ed88cd1cfd0d15aca846da7e (patch) | |
| tree | e102ac0925b397275eed560e82f0042dc2d97995 /compiler/rustc_const_eval | |
| parent | 1025a12b64a7e5d852e02d59d86aca558733bed1 (diff) | |
| download | rust-64cd13ff3b9b5ca0ed88cd1cfd0d15aca846da7e.tar.gz rust-64cd13ff3b9b5ca0ed88cd1cfd0d15aca846da7e.zip | |
add test for GVN issue; cleanup in dataflow_const_prop
Diffstat (limited to 'compiler/rustc_const_eval')
| -rw-r--r-- | compiler/rustc_const_eval/src/interpret/operand.rs | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/compiler/rustc_const_eval/src/interpret/operand.rs b/compiler/rustc_const_eval/src/interpret/operand.rs index 80d4bda4827..4653c9016c6 100644 --- a/compiler/rustc_const_eval/src/interpret/operand.rs +++ b/compiler/rustc_const_eval/src/interpret/operand.rs @@ -260,8 +260,12 @@ impl<'tcx, Prov: Provenance> ImmTy<'tcx, Prov> { // This makes several assumptions about what layouts we will encounter; we match what // codegen does as good as we can (see `extract_field` in `rustc_codegen_ssa/src/mir/operand.rs`). let inner_val: Immediate<_> = match (**self, self.layout.abi) { - // if the entire value is uninit, then so is the field (can happen in ConstProp) + // If the entire value is uninit, then so is the field (can happen in ConstProp). (Immediate::Uninit, _) => Immediate::Uninit, + // If the field is uninhabited, we can forget the data (can happen in ConstProp). + // `enum S { A(!), B, C }` is an example of an enum with Scalar layout that + // has an `Uninhabited` variant, which means this case is possible. + _ if layout.abi.is_uninhabited() => Immediate::Uninit, // the field contains no information, can be left uninit // (Scalar/ScalarPair can contain even aligned ZST, not just 1-ZST) _ if layout.is_zst() => Immediate::Uninit, |
