diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-02-13 17:38:11 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-13 17:38:11 +0100 |
| commit | b785fdb80b86abedc30ba0d1f7027066454ed4bd (patch) | |
| tree | b31aab3c1c47a141069a88d363e8c67dd3cfe2c6 /compiler/rustc_errors/src/snippet.rs | |
| parent | 93e9579b5dc6148fd4bb91112c954eff22f41774 (diff) | |
| parent | faaf81bbbcd5114ad8268190f3cc235868997ae3 (diff) | |
| download | rust-b785fdb80b86abedc30ba0d1f7027066454ed4bd.tar.gz rust-b785fdb80b86abedc30ba0d1f7027066454ed4bd.zip | |
Rollup merge of #120978 - Nadrieril:sane-blocks, r=matthewjasper
match lowering: simplify block creation Match lowering was doing complicated things with block creation. As far as I can tell it was trying to avoid creating unneeded blocks, but of the three places that start out with `otherwise = &mut None`, two of them called `otherwise.unwrap_or_else(|| self.cfg.start_new_block())` anyway. As far as I can tell the only place where this PR makes a difference is in `lower_match_tree`, which did indeed sometimes avoid creating the unreachable final block + FakeRead. Unless this is important I propose we do the naive thing instead. I have not checked all the graph isomorphisms by hand, but at a glance the test diff looks sensible. r? `@matthewjasper`
Diffstat (limited to 'compiler/rustc_errors/src/snippet.rs')
0 files changed, 0 insertions, 0 deletions